Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Final v2 refactor changes #285

Merged
merged 10 commits into from
Dec 15, 2022
Merged

Final v2 refactor changes #285

merged 10 commits into from
Dec 15, 2022

Conversation

AugustoL
Copy link
Member

@AugustoL AugustoL commented Dec 14, 2022 •
edited
Loading

  • Remove _ used for variable names, leaving the _ to be used only for internal functions.
  • Change decision for options, using options to refer as vote options. Proposal -> Options (NO< YES) -> Calls
  • Rename some variables to avoid shadow variable name declaration.
  • Fix almost all compiler warnings.

@AugustoL AugustoL changed the title Final vm v2 refactor Final v2 refactor changes Dec 15, 2022
@AugustoL AugustoL marked this pull request as ready for review December 15, 2022 13:33
@AugustoL AugustoL merged commit 1dfcdff into DXgovernance:v2.0 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiltonTulli MiltonTulli MiltonTulli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AugustoL @MiltonTulli