Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes DAO Final Audit Report #300

Merged
merged 27 commits into from
Mar 6, 2023

Conversation

AugustoL
Copy link
Member

@AugustoL AugustoL commented Jan 18, 2023

Hola, quite packed PR with the last fixes and reactors based on the last audit report from Omega team.

  • Removed some unnecessary variables in like isSchemeRegistered in the controller and totalStaked in VM.
  • Refactor to not call snapshot too often in DAOReputation token.
  • Refactor in VM to allow withdrawal refund vote balance from avatar.
  • Execute function in VM now returns true based in execution success.
  • Refactor redeem function in VM.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…f executed or not

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…posals is reached
…tion

According to the final audit report is better to do all state changes before doing arbitrary calls,
so the state of the proposal in the scheme now it is changed in storage before the calls are done,
despite the try and catch used in the voting machine it is possible for that state storage change if
executeProposal reverts, this is why after executeProposal we still cann finishProposal, that it
will only change the state form submitted to passed or rejected if it wasnt done in the proposal
execution.
@AugustoL AugustoL changed the title Fix dao final audit report Fixes DAO Final Audit Report Jan 23, 2023
@rossneilson
Copy link
Collaborator

Are we good to merge this into v2 so we can have that branch to begin work on subgraph and DAVI?

@AugustoL AugustoL force-pushed the fix-dao-final-audit-report branch from 3fbad46 to b0f55c8 Compare February 23, 2023 15:30
@AugustoL AugustoL merged commit dc3e2ec into DXgovernance:v2.0 Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants