-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes DAO Final Audit Report #300
Merged
AugustoL
merged 27 commits into
DXgovernance:v2.0
from
AugustoL:fix-dao-final-audit-report
Mar 6, 2023
Merged
Fixes DAO Final Audit Report #300
AugustoL
merged 27 commits into
DXgovernance:v2.0
from
AugustoL:fix-dao-final-audit-report
Mar 6, 2023
+2,510
−1,836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n multiple in ERC20Snapshot
…oting machine and tests
…f executed or not
…posals is reached
…tion According to the final audit report is better to do all state changes before doing arbitrary calls, so the state of the proposal in the scheme now it is changed in storage before the calls are done, despite the try and catch used in the voting machine it is possible for that state storage change if executeProposal reverts, this is why after executeProposal we still cann finishProposal, that it will only change the state form submitted to passed or rejected if it wasnt done in the proposal execution.
…ests using Create2Deployer
… staking token transfer success
Are we good to merge this into v2 so we can have that branch to begin work on subgraph and DAVI? |
…in VM stake redeem
… on winning NO option
…TokenBalance on redeems
…Winnings in VM redeem
3fbad46
to
b0f55c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hola, quite packed PR with the last fixes and reactors based on the last audit report from Omega team.