WIP: Increase max network packet sizes #1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase the maximum length of a network message from 32768 bytes to 262144. Also increased max packet length from 1400 bytes to 265000 bytes, because packet fragmenting is not working correctly with larger message sizes.
slipher
reviewed
May 4, 2024
| @@ -59,7 +59,7 @@ to the new value before sending out any replies. | |||
|
|
|||
| */ | |||
|
|
|||
| static const int MAX_PACKETLEN = 1400; // max size of a network packet | |||
| static const int MAX_PACKETLEN = 265000; // max size of a network packet | |||
There was a problem hiding this comment.
You can't just make the size of the real packet arbitrarily large. Some people suggest the current value is good for Ethernet. And supposedly a packet this large would be immediately rejected by any of our supported operating systems. Finally Cloudflare says that sending any packets larger than 1500 is likely to be broken.
|
Proper fix is in #1427. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the maximum length of a network message from 32768 bytes to 262144. Also increased max packet length from 1400 bytes to 265000 bytes, because packet fragmenting is not working correctly with larger message sizes.
This allows for more entities on the map, and brings the soft limit on the amount of buildings from ~250 to ~2k.
Tested with https://users.unvanquished.net/~sweet/layouts/spacetracks/humanpve1.dat (layout for map
spacetracks): doesn't crash anymore, the game loads fine.I'm getting a stack overflow when trying to connect to a server for some reason though.