Tessellation and renderer debug utils cleanup #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a variable intended to track which attributes have been set when using the "dynamic" VBO. It was only read in Tess_StageIteratorDebug. The idea didn't work that well since sometimes there were multiple functions called that add different subsets of attributes, and sometimes code fills in attributes that we don't really care about (e.g. the add cube routine used in debug drawing adding tangents).
I always thought "tangent spaces" must be some fancy math thing, but actually the word "spaces" was there for no reason and the meaning of the flag is very simple.
Fix several problems with bone name debug drawing: - Compiler warnings - Text not drawn at all because charsetImageHash pointed at a random non-font image - Enabling bone names messed up bone colors - Don't stop if the name contains a space - Wrong names for IQM bones
Use the Tess_Begin/End workflow consistently, as opposed to manually setting tess.numIndexes = 0 etc. Fixes some log warnings which were caused by calling gl_genericShader->SetVertexAttribPointers().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.