Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable overbright by default + make fully configurable #1350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable overbright by default + make fully configurable #1350

wants to merge 1 commit into from

Commits on Oct 12, 2024

  1. Disable overbright by default + make fully configurable 

    1. Change cvars so that all overbright settings can easily be tested.
The current overbright-related cvars have a wonky asymmetric design that can make it impossible to test a setting without editing the map. Fix that. With this commit we can use r_overbrightDefaultExponent (0-3) and r_overbrightDefaultClamp (on/off) to control the default settings when the map doesn't say anything, and one more cvar r_overbrightIgnoreMapSettings to make those cvar values override the worldspawn values even if present. In the worldspawn entity mapOverBrightBits can stay as is, but forceLegacyOverBrightClamping drops the "force" (since it is no longer a one-way switch) and renames to just overbrightClamping.

2. Set overbright clamping on by default.
If nothing else we should be true to the intentions of the authors of our own official maps, who were definitely targeting a renderer with clamping. For older maps, the .ent file may be used in restoration efforts if non-default settings look better.

Fixes DaemonEngine#1289.
    @slipher
    slipher committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    cb530f2 View commit details
    Browse the repository at this point in the history