Fix dynamic lights intensity, cleanup #1425
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a cheat cvar used for dynamic lights that have no intensity set, and set to 2.0 for absolutely no reason whatsoever.
…ET() to RE_AddDynamicLightToScene() These were largely doing the same thing, use just one function instead.
|
Why don't we nuke the |
This has largely the same functionality as trap_R_AddLightToScene().
VReaperV
force-pushed
the
reaper/fix-dynamic-lights-intensity/sync
branch
from
b628f0a
to
0670349
Compare
Right, done now. |
This was only used to scale the light's colour, just multiply the colour with it earlier on instead.
VReaperV
force-pushed
the
reaper/fix-dynamic-lights-intensity/sync
branch
from
50875cb
to
ffb8083
Compare
slipher
reviewed
Nov 15, 2024
| light->l.scale = -intensity; | ||
| else | ||
| light->l.scale = intensity; | ||
| if ( light->l.inverseShadows ) { |
There was a problem hiding this comment.
The forward lighting shader checks the sign of u_LightScale to check for inverse lights. These are said to be already broken, but it would be nice to set the scale to 1 or -1 to at least gesture at how it was supposed to work
|
I tested this branch vs. master and found the dynamic lights are not as bright. I guess if you deleted a factor of 8 of random scaling, you need to add that back in somewhere to get the same result? Master: This branch: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cgame-side pr: Unvanquished/Unvanquished#3184
r_lightScalecvar, which is used for dynamic lights, but it's a cheat cvar and always set to 2.0, and essentially only used for dynamic lights spawned from moversRE_AddDynamicLightToSceneQ3A()and renamedRE_AddDynamicLightToSceneET()toRE_AddDynamicLightToScene()because they're essentially the sametrap_R_AddAdditiveLightToScene()Fixes #61:
hq-beta28:Before:
After:
tremtest:Before:
After: