Fix daemonded not starting on Mac #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow bind() has the same filename length limit from the 1970s and there is no alternative API that can use a longer name. Recent MacOS versions generate a long random path for TMPDIR, which causes a fatal error for daemonded - DaemonEngine#1390 (the server uses a slightly longer path than the client).
Because I want to use pthread_chdir. Needs to be updated in the release script too.
The default profile now generates a ~50-character-long $TMPDIR by default (I assume it must have been shorter before). The singleton socket path we generate for daemonded ends up too long for the `bind` or `connect` APIs. (The socket path for clients is slightly shorter and just sneaks under the limit.) Work around this by using the Mac-specific pthread_chdir_np API to thread-safely change the CWD to the directory with the socket, accessing it with a relative path, then resetting the current directory to what it was before. Fixes DaemonEngine#1390.
|
With the bump of |
|
I confirm it builds in dockerized release script and that the produced binaries work and the bug is fixed. GG! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1390.