Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some dynamic buffer-related clean-up and fixes #1528

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Some dynamic buffer-related clean-up and fixes #1528

wants to merge 4 commits into from

Conversation

VReaperV
Copy link
Contributor

  • NUKED useless GL_ARB_buffer_storage and GL_ARB_sync macro checks.
  • Fix bogus checks for SHADER_MAX_VERTEXES and SHADER_MAX_INDEXES for cases where the dynamic buffers are not being used by adding a check for r_vboModels. Also changed it to a new-style cvar.
  • Some small clean-up of Ringbuffer functions and more stuff in logs.

@VReaperV VReaperV force-pushed the cleanup-dynamic-buffers branch from 2c6a5b6 to 5d7425c Compare January 28, 2025 20:35
@VReaperV
NUKE useless GL_ARB_buffer_storage and GL_ARB_sync macro checks
d33fe99 
These are already inherently a part of `glConfig2.bufferStorageAvailable` and `glConfig2.syncAvailable`, the macros do nothing.
@VReaperV
Change r_vboModels to a new-style cvar
c19fd0d
@VReaperV
Fix bogus checks for SHADER_MAX_VERTEXES and SHADER_MAX_INDEXES
d0a761a 
These make no sense when static VBOs are used, so only do those checks if `r_vboModels` is disabled.
@VReaperV
Some Ringbuffer cleanup
6b1428c
@VReaperV VReaperV force-pushed the cleanup-dynamic-buffers branch from 5d7425c to 6b1428c Compare January 30, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Renderer T-Bug T-Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@VReaperV