-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix texture rotation, <3 @gimhael, fix #35 #208
Conversation
From up to down: scenes known to previously reproduce the bug in parpax map (Unvanquished), train map (Smokin' Guns), metro map (Tremulous). |
I added the second occurrence of the I quoted some of your words to prevent people to drop or leftover this trick in future optimization/revamp. |
does anyone has anything to say more? |
LGTM, though it may be more optimal to just bake the translation into the texture transform matricies. That way, you wouldn't sacrifice texture coord precision. It is unlikely to be that much of an issue though. |
I'm not sure to understand how to do it. So code that works that exists is better than code that may be better but does not exist 😛. |
@cmf028 I'm merging it. If you have a better idea feel free to submit a PR but I would prefer seeing progress on some other projects you know better than me. 😁 |
code by @gimhael 🍾 💯 🎉
it works and fix #35: