Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix texture rotation, <3 @gimhael, fix #35 #208

Merged
merged 1 commit into from
Jul 8, 2019

Conversation

illwieckz
Copy link
Member

@illwieckz illwieckz commented Jul 1, 2019

code by @gimhael 🍾 💯 🎉

it works and fix #35:

parpax fan

train fan

metro fan

@illwieckz
Copy link
Member Author

illwieckz commented Jul 2, 2019

From up to down: scenes known to previously reproduce the bug in parpax map (Unvanquished), train map (Smokin' Guns), metro map (Tremulous).

@illwieckz
Copy link
Member Author

I added the second occurrence of the - 0.5 trick to be consistent.

I quoted some of your words to prevent people to drop or leftover this trick in future optimization/revamp.

@illwieckz
Copy link
Member Author

does anyone has anything to say more?

@cmf028
Copy link
Contributor

cmf028 commented Jul 8, 2019

LGTM, though it may be more optimal to just bake the translation into the texture transform matricies. That way, you wouldn't sacrifice texture coord precision. It is unlikely to be that much of an issue though.

@illwieckz
Copy link
Member Author

I'm not sure to understand how to do it. So code that works that exists is better than code that may be better but does not exist 😛.

@illwieckz
Copy link
Member Author

@cmf028 I'm merging it. If you have a better idea feel free to submit a PR but I would prefer seeing progress on some other projects you know better than me. 😁

@illwieckz illwieckz merged commit 5f57ba0 into DaemonEngine:master Jul 8, 2019
@illwieckz illwieckz deleted the fixrotate branch January 18, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

broken rotating texture
4 participants