-
Notifications
You must be signed in to change notification settings - Fork 7
add cmake support #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
add cmake support
legacy Makefile does not compile them and it works lzma_Threads rely on process.h that looks to be a win32 thing
crunch/CMakeLists.txt
Outdated
@@ -0,0 +1,21 @@ | |||
set(CMAKE_CXX_STANDARD 14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, it's a line from that foreign branch I merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This forces C++14 standard. You probably don't want that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boxerab Ok thank you for the prompt answer, I'll remove it then :-)
extra:
See also that alternative (some bits can be interesting) on the old binomial branch: madebr@eea5a8d