Skip to content

add cmake support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 6, 2018
Merged

add cmake support #5

merged 8 commits into from
May 6, 2018

Conversation

illwieckz
Copy link
Member

@illwieckz illwieckz commented May 6, 2018

extra:

  • add clean-up target to legacy Makefile

See also that alternative (some bits can be interesting) on the old binomial branch: madebr@eea5a8d

@@ -0,0 +1,21 @@
set(CMAKE_CXX_STANDARD 14)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, it's a line from that foreign branch I merged

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This forces C++14 standard. You probably don't want that :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boxerab Ok thank you for the prompt answer, I'll remove it then :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants