Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datasource: Handle pandas timestamp in df upload #511

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Datasource: Handle pandas timestamp in df upload #511

merged 1 commit into from
Aug 1, 2024

Conversation

kbolashev
Copy link
Member

Currently uploading a dataframe with pandas' Timestamp objects fails.
This PR fixes it, converting them to datetimes.

@kbolashev kbolashev added the bug Something isn't working label Aug 1, 2024
@kbolashev kbolashev self-assigned this Aug 1, 2024
@dagshub DagsHub
Copy link

dagshub bot commented Aug 1, 2024

Join the discussion on DagsHub!

guysmoilov
guysmoilov approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@guysmoilov guysmoilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.
I think the more elegant systematic solution might be to check the superclasses but maybe that's too aggressive

@kbolashev kbolashev merged commit c2ceba8 into master Aug 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysmoilov guysmoilov guysmoilov approved these changes

Assignees

@kbolashev kbolashev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbolashev @guysmoilov