Add a fallback on annotation validation #531
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a malformed annotation on a datapoint (or an annotation that failed to parse, not even malformed) right now leads to the whole loading process failing.
This PR is a hotfix to prevent that.
If an annotation fails to parse, it gets shown to the user in a warning message, and I warn them that they won't be able to interact with them, for example:
I'm not handling these bad annotations in other downstream functions for now properly, if we do want to make it have a nice UX, would probably need to have some kind of
BrokenAnnotation
class that will shim the regular annotation functions and display a warning.Not sure if it's worth it to work on this right now