[ayosecu] WEEK 01 solutions #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
제가 아직 contains duplicate 외에 다른 문제는 못봐서요 ㅠㅠ 우선 approve 하고, 이번주 내로 문제 풀면서 코드리뷰 코멘트 남겨놓을게요!! |
paran22
approved these changes
Apr 1, 2025
| - Space Complexity: O(N) | ||
| - N = len(set_check) = The number of unique numbers | ||
| - If there is no duplicated numbers, N = n | ||
| """ |
There was a problem hiding this comment.
문제마다 시간복잡도/공간복잡도 추가해주시는거 너무 좋은데요?!!
저는 계산해도 시간복잡도만 체크했는데 덕분에 공간복잡도 계산하는 것도 배우고 갑니다!! 👍
paran22
reviewed
Apr 2, 2025
| """ | ||
| def twoSum(self, nums: List[int], target: int) -> List[int]: | ||
| # Save "num:index" key-value to a dictionary | ||
| dic = {} |
There was a problem hiding this comment.
dictionary 이용하니까 for문 이중으로 쓰지 않아도 되서 시간복잡도도 줄어들고 좋네요!!
index도 같이 저장할 수 있구요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!