[PDKhan] WEEK 01 solutions #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krokerdile
reviewed
Mar 31, 2025
| for(int i = 0; i < nums.size(); i++){ | ||
| map[nums[i]]++; | ||
|
|
||
| if(map[nums[i]] == 2) |
There was a problem hiding this comment.
map에 추가하면서 2번 이상 추가된 요소면 종료 하는 방식이군요! 저는 추가를 완료하고 조회를 하도록 했는데 더 좋은 방식인 것 같습니다. 참고하겠습니다 👍
There was a problem hiding this comment.
저는 추가하면서 2번 이상이면 바로 종료가 되는 것이 더 빠르다고 판단했습니다.
근데 다른 분 리뷰하면서 보니 set 으로 이미 set 에 있으면 종료하는 방식도 있는데 이 것도 추천드립니다.
There was a problem hiding this comment.
오 좋은 방법인 것 같습니다. 저도 코드 한번 짜봐야겠네요! 감사합니다
There was a problem hiding this comment.
혹시 리뷰 완료가 가능하실지 문의 드립니다.
오늘까지 PR merge 완료해야 할듯 해서요~
There was a problem hiding this comment.
네넵 제가 승인 하는 걸 깜박했네요, 죄송합니다! 해두겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!