[박종훈] 6주차 답안 제출 #115
Merged
[박종훈] 6주차 답안 제출 #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamTheKorean
approved these changes
Jun 4, 2024
빠르게 풀고 다른 분들 코드 리뷰 같이 하려고요...! ㅎㅎ |
DaleSeo
approved these changes
Jun 5, 2024
Comment on lines
+9
to
+11
| if (s.isEmpty()) { | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
이런 류의 체크는 큰 의미없이 코드의 길이만 늘릴 수 있지 않을까요? 얼마큼의 연산량이 아껴지는지 생각해보시면 좋을 것 같습니다. 특히 자바 같이 코드가 긴 편에 속하는 언어에서는 오히려 득보다 해가 될 수 있다고 생각합니다.
Comment on lines
+17
to
+25
| while (pointer < s.length()) { | ||
| char _char = s.charAt(pointer); | ||
| while (set.contains(_char)) { | ||
| set.remove(s.charAt(pointer - set.size())); | ||
| } | ||
| set.add(_char); | ||
| longest = Math.max(longest, set.size()); | ||
| pointer++; | ||
| } |
There was a problem hiding this comment.
중복이 되면 안된다는 조건이 있어서 Set을 사용해보았습니다 : )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container With Most Water
문제: https://leetcode.com/problems/container-with-most-water/
풀이: https://algorithm.jonghoonpark.com/2024/06/02/leetcode-11
Longest Substring Without Repeating Characters
문제: https://leetcode.com/problems/longest-substring-without-repeating-characters/
풀이: https://algorithm.jonghoonpark.com/2024/02/18/leetcode-3
Longest Repeating Character Replacement
문제: https://leetcode.com/problems/longest-repeating-character-replacement/
풀이: https://algorithm.jonghoonpark.com/2024/04/29/leetcode-424
Find Minimum In Rotated Sorted Array
문제: https://leetcode.com/problems/find-minimum-in-rotated-sorted-array/
풀이: https://algorithm.jonghoonpark.com/2024/06/03/leetcode-153
Search In Rotated Sorted Array
문제: https://leetcode.com/problems/search-in-rotated-sorted-array/
풀이: https://algorithm.jonghoonpark.com/2024/06/03/leetcode-33