-
-
Notifications
You must be signed in to change notification settings - Fork 195
[seungseung88] WEEK 02 solutions #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
valid-anagram/seungseung88.js:19
- [nitpick] Consider renaming the variable 'i' to a more descriptive name (e.g., 'freq') to better convey that it represents character frequency differences.
for (const i of Object.values(count)) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
valid-anagram/seungseung88.js:19
- [nitpick] Consider renaming the variable 'i' to a more descriptive name like 'countValue' or 'frequency' to improve code readability.
for (const i of Object.values(count)) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
valid-anagram/seungseung88.js:19
- [nitpick] Consider renaming the variable 'i' to a more descriptive name, such as 'frequency', to improve code clarity.
for (const i of Object.values(count)) {
climbing-stairs/seungseung88.js:8
- [nitpick] Consider renaming 'arr' to a more descriptive variable like 'dp' or 'steps' to clarify its purpose as a dynamic programming array.
const arr = [1, 2];
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
시간, 공간복잡도 효율을 생각하며 잘 작성해주신 거 같습니다 LGTM!
count[t[i]] = (count[t[i]] || 0) - 1; | ||
} | ||
|
||
for (const i of Object.values(count)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for in 연산으로 바꾸셔서 Object.values 메소드 배열 생성으로 인한 비용을 줄여서 작성하시면 더 효율적일 거 같습니다!
답안 제출 문제
작성자 체크 리스트
In Review
로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!