-
-
Notifications
You must be signed in to change notification settings - Fork 195
[shinsj4653] Week 03 Solutions #1272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR includes the Week 03 Solutions with implementations and reflective comments for multiple algorithm problems. Key changes include:
- Additional reflective notes (회고) and approach explanations across the solutions.
- New solution files for problems such as valid-palindrome, number-of-1-bits, maximum-subarray, decode-ways, and combination-sum.
- Updated implementations, including both dynamic programming and recursive approaches in decode-ways and combination-sum.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
validate-binary-search-tree/shinsj4653.py | Added a reflective note about passing upper and lower bounds. |
valid-palindrome/shinsj4653.py | Added a basic structure with explanations for the valid-palindrome problem. |
number-of-1-bits/shinsj4653.py | Added a problem explanation and structure for the number-of-1-bits solution. |
maximum-subarray/shinsj4653.py | Implemented the Kadane’s algorithm with reflective notes on the approach. |
decode-ways/shinsj4653.py | Provided three solution approaches (recursive with memoization and bottom-up DP) with commentary. |
combination-sum/shinsj4653.py | Offered two implementations (DP-based and recursive) with detailed reflections and notes. |
if start_idx >= n : | ||
return | ||
for i in range(1, 2): | ||
num = int(s[start_idx:start_idx + i] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing parenthesis in the int conversion. Consider updating the line to 'num = int(s[start_idx:start_idx + i])'.
num = int(s[start_idx:start_idx + i] | |
num = int(s[start_idx:start_idx + i]) |
Copilot uses AI. Check for mistakes.
저를 리뷰어로 할당하신 이유가 있을까요? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
한주에 리뷰를 2번 하게 되지만 일단 요청하셔서 리뷰합니다.
3주차 수고하셨습니다.
답안 제출 문제
작성자 체크 리스트
In Review
로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!