[Leo] 7th Week solutions #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
파이썬은 제게 생소함에도 불구하고, 코드를 읽는데 편안하고 어렵지 않았습니다. |
yolophg
approved these changes
Jun 15, 2024
| @@ -0,0 +1,12 @@ | |||
| class Solution: | |||
| def isValidBST(self, root: Optional[TreeNode]) -> bool: | |||
There was a problem hiding this comment.
Typescript 처럼, 반환 타입을 지정할 수 있는 코드들이 흥미로웠습니다.
확실히 타입을 지정하니 가독성도 올라가고 훨씬 좋네요!
| for i in range(n): | ||
| right = right.next | ||
|
|
||
| if not right: return head.next |
There was a problem hiding this comment.
JS와 다르게 아주 간단히 not 연산자만으로 조건을 확인하고 반환할 수 있다는 점이 좋네요!
Comment on lines
+3
to
+8
| def helper(node, low, high): | ||
| if not node: | ||
| return True | ||
| if not (low < node.val < high): | ||
| return False | ||
| return helper(node.left, low, node.val) and helper(node.right, node.val, high) |
There was a problem hiding this comment.
helper 함수를 활용하여 모듈화를 하신 점, 너무 좋은 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.