[chrisjune] week 01 solutions #1708
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0ooo0k
reviewed
Jul 23, 2025
There was a problem hiding this comment.
안녕하세요! 다음 PR 제출자가 이전 PR의 리뷰어가 되는 구조라, 제가 @chrisjune 님의 리뷰어가 되는 거 같습니다 :) 확인하시면 수정 부탁드릴게요!
빠르게 문제를 풀어주셨네요, 나머지 문제들도 빠른 시일 내에 리뷰 남겨 드리겠습니다,
파이썬 언어를 안한지가 오래 되어 가물가물하지만, 덕분에 다시 한 번 리마인드 해보겠습니다!
two-sum/chrisjune.py
Outdated
Comment on lines
6
to
9
| for i in range(len(nums)): | ||
| for j in range(len(nums)): | ||
| if i == j: | ||
| continue |
There was a problem hiding this comment.
저도 처음에 이중 for문으로 풀었었는데, 파이썬의 경우 dictionary를 사용하면 시간복잡도를 줄일 수 있는 방법으로도 풀 수 있을 거 같습니다!
There was a problem hiding this comment.
리뷰 감사합니다. 의견주신 dictionary로 풀었더니 속도개선이 잘 되었습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!