[jangwonyoon] WEEK 01 solutions #1712
Merged
+157
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nancyel
reviewed
Jul 26, 2025
| */ | ||
| var containsDuplicate = function(nums) { | ||
| const sortedNums = nums.sort((a, b) => a - b); | ||
| const length = sortedNums.length - 1; |
There was a problem hiding this comment.
length 변수가 재사용되지 않는다면 아래 for loop 구문에 바로 넣으면 어떨까요?
There was a problem hiding this comment.
보기 좋게 쓸 변수로 사용했는데, 생각해보니 재사용 되지 않는다면, 메모리만 사용하는 상황이네요 리뷰 감사합니다.
nancyel
reviewed
Jul 26, 2025
| * @return {number} | ||
| */ | ||
| var longestConsecutive = function(nums) { | ||
| let longest = 0; |
There was a problem hiding this comment.
변수 이름이 명확해서 코드의 흐름을 파악하기 쉽네요!
nancyel
reviewed
Jul 26, 2025
| } | ||
|
|
||
| map.set(nums[i], i); | ||
| } |
There was a problem hiding this comment.
twoSum 함수의 리턴값의 타입이 number[] 이면 for loop 을 모두 순회한 후 리턴값으로 빈 배열을 반환하면 어떨까요?
|
고생하셨습니다! |
nancyel
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!