[khg0712] WEEK 01 solutions #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHYjun
reviewed
Nov 8, 2025
|
|
||
|
|
||
| for (const index of nums.keys()) { | ||
| const v = nums[index]; |
Contributor
There was a problem hiding this comment.
nit: LeetCode에서 복붙하시다가 indentation이 어긋난 거 같습니다.
WHYjun
reviewed
Nov 8, 2025
| } | ||
|
|
||
| // 한 번 사용한 숫자는 제거 | ||
| set.delete(_num); |
Contributor
There was a problem hiding this comment.
Typescript for loop과 Set이 어떻게 작동하는지 모르지만, iteration 중에 건드는 것은 위험할 것 같습니다. 혹시 위험하지 않은 이유가 있다면 설명해주시면 배우도록 하겠습니다.
HashSet에서 lookup 하는 건 O(1)이라 HashSet의 크기는 별로 중요하지 않을 거 같고. isStart로 이미 시작 시점이 되는 숫자부터 확인하도록 하셨기 때문에 이 부분이 없어도 답을 구하는데 문제 없어 보입니다.
TonyKim9401
approved these changes
Nov 16, 2025
Contributor
TonyKim9401
left a comment
TonyKim9401
left a comment
There was a problem hiding this comment.
1주차 문제 풀이 고생하셨습니다!
온보딩 및 스터디 적응 하시는데 앞으로 조금 더 힘내주시고 앞으로의 15주간 여정 응원합니다.
2주차 문제 풀이도 파이팅입니다!
Contributor
|
디스코드와 깃허브 닉네임 매칭 부탁드립니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
작성자 체크 리스트
In Review로 설정해주세요.검토자 체크 리스트
Important
본인 답안 제출 뿐만 아니라 다른 분 PR 하나 이상을 반드시 검토를 해주셔야 합니다!