Skip to content

Sam's week 1 solutions #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Sam's week 1 solutions #22

merged 2 commits into from
Apr 29, 2024

Conversation

SamTheKorean
Copy link
Contributor

No description provided.

@SamTheKorean SamTheKorean changed the title Sam Sam's week 1 solutions Apr 25, 2024
@DaleSeo DaleSeo added the week1 label Apr 25, 2024
@SamTheKorean SamTheKorean added bug Something isn't working and removed bug Something isn't working labels Apr 25, 2024
@DaleSeo DaleSeo added this to the week1 milestone Apr 28, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 풀이는 일부러 defaultdict 를 안쓰고 풀으신건가요? 지난번에 질문 올리신걸 본 거같은데 기억이 잘 안나네요 :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의도하고 defaultdict을 안쓴 건 아니지만 처음엔 defaultdict을 고려하지 않았지만 후에 defaultdict과 일반 딕셔너리의 성능차이는 없는 것 같아 처음 솔루션을 그대로 커밋했습니다! 혹시 my_dict1.get(char, 0) + 1 연산을 하는 것보다 defaultdict이 더 효율적이라 말씀하시는 걸까요?

질문은 디코채널 도와주세요 - 코딩테스트 - Valid anagram에 있습니다 ㅎㅎ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 아뇨 ㅋㅋ 질문하실 때 한 개만 쓴게 낫냐고 여쭤보신거 같은데 그대로 올리셨길래 뭔가 다른 이유가 있나 싶어서 여쭤봤던거예요 ㅋㅋㅋ 어차피 두 방법 다 큰 차이는 없어보입니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 아뇨 ㅋㅋ 질문하실 때 한 개만 쓴게 낫냐고 여쭤보신거 같은데 그대로 올리셨길래 뭔가 다른 이유가 있나 싶어서 여쭤봤던거예요 ㅋㅋㅋ 어차피 두 방법 다 큰 차이는 없어보입니다!

@leokim0922 leokim0922 merged commit 1355050 into DaleStudy:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants