[영우] Week 1 풀이 제출 #304
Merged
[영우] Week 1 풀이 제출 #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YeonguChoe
commented
Aug 11, 2024
•
YeonguChoe
commented
- contain duplicate
- number of 1 bits
- top k frequent elements
- k th smallest elements in BST
- palindromic substring
|
커밋 메시지 는 무슨 작업을 했는지 담기면 좋을 것 같습니다. |
There was a problem hiding this comment.
해당 문제도 시 공간 복잡도 넣어주시면 좋을 것 같습니다!
There was a problem hiding this comment.
For 문안에 while 문을 넣는다고 반드시 O(n^2)이 될까요?ㅎㅎ
There was a problem hiding this comment.
제가 보기에도 O(N^2)같은데, Sam님 의견이 궁금합니다
There was a problem hiding this comment.
요것도 시 공간 복잡도 추가부탁드립니다!
|
원래 제가 리뷰해야할 HajoonYu 님의 2기 참여 여부가 불확실한 것 같아서, 영우님 답안 리뷰어로 참여하겠습니다 |
EgonD3V
approved these changes
Aug 16, 2024
Comment on lines
+13
to
+14
| priority_queue<int, vector<int>, decltype(comparator)> min_heap( | ||
| comparator); |
There was a problem hiding this comment.
STL을 쓰는 것도 좋지만 한 번 구현해서 써보시면 STL 사용금지인 코딩테스트에서 도움되실 것 같습니다
obzva
approved these changes
Aug 16, 2024
| for (int i = 0; i < s.size(); i++) { | ||
| output += find_palindrome1(s, i); | ||
| } | ||
| for (int i = 0; i < s.size() - 1; i++) { |
There was a problem hiding this comment.
안녕하세요 영우님, 풀이 잘 보았습니다 :D
제가 보기엔 두번째 for문이 불필요해보입니다
첫번째 for문 안에서 find_palindrome1과 find_palindrome2를 모두 실행해도 되지 않을까요?
|
@YeonguChoe 님, 다른 분들 피드백 확인 부탁드리며 모임 전까지 PR 병합 부탁드리겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.