[sun] W1 Solutions #315
Merged
[sun] W1 Solutions #315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sun912
commented
Aug 12, 2024
•
sun912
commented
- contains-duplicate
- number-of-1-bits
- Top K Frequent Elements
- Kth Smallest Element In a Bst
- Palindromic Substrings
DaleSeo
reviewed
Aug 13, 2024
| result += n % 2 | ||
| n = n//2 | ||
|
|
||
| return result |
There was a problem hiding this comment.
옷, 파일 마지막에 line break가 빠져있네요.
참고: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
There was a problem hiding this comment.
옷, 파일 마지막에 line break가 빠져있네요. 참고: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
저는 Python 컨벤션으로 알고 있었는데, 근본의 UNIX 기원이군요 감사합니다
sun912
requested review from
0-Chan and
naringst
and removed request for
0-Chan
EgonD3V
approved these changes
Aug 16, 2024
| result += n % 2 | ||
| n = n//2 | ||
|
|
||
| return result |
There was a problem hiding this comment.
옷, 파일 마지막에 line break가 빠져있네요. 참고: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
저는 Python 컨벤션으로 알고 있었는데, 근본의 UNIX 기원이군요 감사합니다
Comment on lines
+23
to
+24
| if len(result) == k: | ||
| return result |
There was a problem hiding this comment.
early return으로 실행 속도 이득을 보는 것도 좋지만, 함수 시그니처에 맞춰서 return을 보장해주는 것도 좋다고 생각합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.