[구문영(GUMUNYEONG)] WEEK 2 Solution #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
GUMUNYEONG
commented
Aug 22, 2024
GUMUNYEONG
commented
- Valid Anagram
- Counting Bits
- Encode and Decode Strings
- Construct Binary Tree From Preorder And Inorder Traversal
- Decode Ways
|
복잡도 분석은 코드에 추가하여 다시 올리겠습니다 |
DaleSeo
approved these changes
Aug 24, 2024
valid-anagram/GUMUNYEONG.js
Outdated
Comment on lines
19
to
25
| } else { | ||
| result = false; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| return result; |
There was a problem hiding this comment.
요렇게 하시면 더 깔끔하고 효율적인 코드가 되지 않을까 생각이 들었습니다 :)
Suggested change
| } else { | |
| result = false; | |
| break; | |
| } | |
| } | |
| return result; | |
| } else { | |
| return false; | |
| } | |
| } | |
| return true; |
There was a problem hiding this comment.
앗 더 간단하게 표현할 수 있었네요..! 피드백 감사합니다! :>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.