[Sophia] Week3 Solutions #394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bky373
reviewed
Aug 30, 2024
| ways[1] = 1; | ||
|
|
||
| for (let i = 2; i <= n; i++) { | ||
| ways[i] = ways[i - 1] + ways[i - 2]; // 점화식 사용 |
There was a problem hiding this comment.
점화식을 이용하신 부분이 좋습니다! 👍 조금 더 개선해서 공간 복잡도를 O(1) 으로 줄여보시면 어떨까요?
HC-kang
approved these changes
Aug 31, 2024
| let twoSum = function (nums, target) { | ||
| let indices = {}; | ||
|
|
||
| nums.forEach((item, index) => { |
There was a problem hiding this comment.
16 line 의 조건을 만족하지 않는 경우, 즉, 필요한 경우에만 indices를 추가해준다면 순회 1회를 줄일 수 있지 않을까요?
| for (let i = 0; i < nums.length; i++) { | ||
| let findNum = target - nums[i]; | ||
|
|
||
| if (indices[findNum] !== i && findNum.toString() in indices) { |
There was a problem hiding this comment.
findNum.toString() 은 아마 object의 key로 number를 사용하는 부분을 신경 써 주신것 같은데 맞을까요?
이런 목적이 맞으시다면, Map을 사용하는것도 좋지 않을까 싶습니다! 의도적으로 object를 사용하셨다면 무시하셔도 좋습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.