[GUMUNYEONG] Week3 문제풀이 #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyejjun
reviewed
Aug 30, 2024
|
|
||
|
|
||
|
|
||
| for (const key in numPair) { |
There was a problem hiding this comment.
저도 비슷하게 풀었습니다!
제가 받은 코드 리뷰에서는 "적절한 자료구조를 활용해서 더 효율적인 방식으로 풀어볼 수 있을 것" 이라고 답변을 받았고 다른 풀이 법을 고민 해 봤습니다.
문영님도 해시맵(Map)과 같은 방법을 활용해 보시는 게 좋을 것 같다는 의견을 남깁니다!
|
안녕하세요~ 이제 자동 워크플로 통해 언어 label 이 알아서 추가되고 있습니다! |
DaleSeo
reviewed
Aug 31, 2024
There was a problem hiding this comment.
입력으로 nums = [0, 0], target = 0이 주어진다면 어떨까요? [0, 1] 대신에 undefined가 반환될 것 같아서 여쭙니다.
There was a problem hiding this comment.
앗...!!!! 네 맞습니다..!! 테스트 케이스 이외에 다른 경우를 고려하지 못했네요..
다음부터는 좀 더 세심하게 여러 케이스를 생각해서 짜야겠습니다.
피드백 감사합니다!
DaleSeo
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제