[sun] WEEK 5 solution #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3Sum 풀었다고 체크가 되어 있는데 빈 파일이네요?
|
bky373
reviewed
Sep 14, 2024
bky373
approved these changes
Sep 14, 2024
leokim0922
reviewed
Sep 14, 2024
| l = 0 | ||
| r = 1 | ||
|
|
||
| while r < len(prices): |
There was a problem hiding this comment.
코드 내용 잘 보았습니다! two pointer를 이용한 솔루션 자체는 이해가 잘 되는데요 아래와 같은 방법으로 조금 더 간결하게 적을 수 있지 않을까 싶어 코멘트 드립니다 😄
max_profit=0
buy = 0 ## l,r 대신 사는날의 인덱스만 표기
for sell in range(1, len(prices)): ## while loop 대신 for loop을 이용해서 sell 포인터를 안으로 포함시켜버리기이렇게 개선하면 조금 더 간결하게 쓸 수 있을거 같아요!
leokim0922
reviewed
Sep 14, 2024
| result.add((nums[i], nums[left], nums[right])) | ||
| left,right = left+1, right-1 | ||
|
|
||
| return list(result) |
There was a problem hiding this comment.
코드 전반적인 내용은 잘 이해가 됩니다만, 요 부분이 조금 신경이 쓰이네요 ㅎㅎ 혹시 result를 시작부터 list로 작성하는 방법도 생각해보셨을까요? 캐스팅을 하더라도 Time complexity가 유의미한 변화가 없는건 이해가 갑니다만, set을 사용하지 않으면 메모리 측면에서 조금 유리하지 않을까 생각이 드네요 😃
leokim0922
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.