[환미니니] 8주차 문제풀이 제출 #509
Merged
[환미니니] 8주차 문제풀이 제출 #509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangodm-web
approved these changes
Oct 5, 2024
| @@ -0,0 +1,37 @@ | |||
| // 시간복잡도: O(m + n) | |||
There was a problem hiding this comment.
clone graph 문제에서 해주신 것처럼 m, n을 무엇으로 정의했는지 적어주면 더 좋을 것 같아요.
merge-two-sorted-lists/hwanmini.js
Outdated
|
|
||
| while (list1 && list2) { | ||
| if (list1.val < list2.val) { | ||
| res.next = new ListNode(list1.val); |
There was a problem hiding this comment.
지금은 순회를 할때마다 새로운 노드를 만들어서 할당하고 있어요.
이걸 개선할 수 있는 방법이 있을까요~? 🤔
There was a problem hiding this comment.
아 기존 리스트 노드를 재활용하면 되겠네요..!
감사합니다 : )
| const visited = new Map() | ||
| visited.set(node, new _Node(node.val)) | ||
|
|
||
| const que = [node] |
There was a problem hiding this comment.
q나 queue로 표현해준다면 더 가독성이 높아질 것 같아요!
There was a problem hiding this comment.
변수명 좀 더 신경써서 지어야겠어요👍
Comment on lines
+25
to
+36
| while (que.length) { | ||
| const curNode = que.shift() | ||
|
|
||
| for (neighbor of curNode.neighbors) { | ||
| if (!visited.has(neighbor)) { | ||
| visited.set(neighbor, new _Node(neighbor.val)); | ||
| que.push(neighbor) | ||
| } | ||
|
|
||
| visited.get(curNode).neighbors.push(visited.get(neighbor)) | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.