[mintheon] Week 1 #633
Merged
[mintheon] Week 1 #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
안녕하세요 @mintheon 님! |
DaleSeo
reviewed
Dec 8, 2024
DaleSeo
reviewed
Dec 8, 2024
minji-go
reviewed
Dec 9, 2024
|
|
||
| PriorityQueue<Entry<Integer, Integer>> pq = new PriorityQueue<>((a, b) -> b.getValue().compareTo(a.getValue())); | ||
| pq.addAll(frequent.entrySet()); | ||
|
|
There was a problem hiding this comment.
PriortyQueue랑 정렬은 시간 복잡도는 O(nlogn)으로 동일하지만, 상위 k개 요소를 구할 때는 PriorityQueue가 더 효율적이겠네요! 하나 배워갑니다 :)
DaleSeo
approved these changes
Dec 10, 2024
Comment on lines
+15
to
+16
| PriorityQueue<Entry<Integer, Integer>> pq = new PriorityQueue<>((a, b) -> b.getValue().compareTo(a.getValue())); | ||
| pq.addAll(frequent.entrySet()); |
There was a problem hiding this comment.
가장 큰 수 k개만 필요한데 반드시 모든 숫자를 정렬해야할까를 고민해보시면 보다 효율적인 알고리즘을 얻으실 수도 있을 것 같습니다.
There was a problem hiding this comment.
가장 큰 수 k개만 필요한데 반드시 모든 숫자를 정렬해야할까를 고민해보시면 보다 효율적인 알고리즘을 얻으실 수도 있을 것 같습니다.
올려주신 풀이의 배열 방법은 생각치 못했어요.
다만 자바로 변환해서 푸니 List<List<>> 방식이 되어 코드가 복잡해지는 경향이 있는것 같아요. 그래도 속도는 확실하네요!! 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.