[yoonthecoder] Week 1 #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoonthecoder님 안녕하세요! |
DaleSeo
approved these changes
Dec 12, 2024
| return nums.length === 0 ? 0 : countSet.size + 1; | ||
| }; | ||
|
|
||
| // Time complexity: O(nlogn) => TODO: need to improve this to O(n) |
There was a problem hiding this comment.
알고리즘 개선 작업을 계획하고 계신 것 같은데, 현재 답안도 충분히 훌륭한 것 같아서 PR은 승인해드리도록 하겠습니다. 승인 후에 추가 커밋을 푸시하셔도 승인이 취소되거나 하지는 않으니 자유롭게 추가 작업하시기 바랍니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.