Skip to content

[hanseulhyi] - Week 1 #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 15, 2024
Merged

[hanseulhyi] - Week 1 #641

merged 6 commits into from
Dec 15, 2024

Conversation

hanseulhee
Copy link
Member

@hanseulhee hanseulhee commented Dec 6, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@hanseulhee hanseulhee self-assigned this Dec 6, 2024
@hanseulhee hanseulhee requested a review from a team as a code owner December 6, 2024 01:12
@github-actions github-actions bot added the js label Dec 6, 2024
@hanseulhee
Copy link
Member Author

바로 앞에 PR을 열어주신 분이 Reviewer 목록에 뜨지 않습니다 🥲

@SamTheKorean
Copy link
Contributor

@Jeehay28 님이 조직 초대를 아직 안받으셔서 그런 것 같습니다! leetcode3 조직에 초대드렸는데 확인부탁드립니다!

@HC-kang HC-kang requested a review from Jeehay28 December 8, 2024 23:54
Copy link
Contributor

@Jeehay28 Jeehay28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contains-duplicate/hanseulhee.js

안녕하세요, 저는 이 문제에 대해서 별로 깊이 생각하지 않고 주어진 배열과, Set 으로 중복을 걸러내고 갯수만 비교했는데, 이렇게 접근하면 중복이 자주 발생하거나 큰 배열을 다룰 때 유리하다고 하네요. 덕분에 새로운 걸 배웠습니다!

@Jeehay28 Jeehay28 self-requested a review December 9, 2024 15:21
@hanseulhee hanseulhee merged commit 2517417 into DaleStudy:main Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants