[seunghyun] Week 2 Solutions #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamTheKorean
approved these changes
May 11, 2024
|
저도 Linked List 문제를 좋아하지 않습니다. 포인터를 활용해서 수정하는 것 자체가 조금 직관적으로 와닿지가 않아서 더 헷갈리는거 같아요. 저는 처음에 이해가 안가면 링크드리스트를 표를 그려서 실제로 코드에서 포인터가 어떻게 옮겨가는지 제가 직접 체크를 해봤습니다. 안해보셨다면 이 방법을 한 번 시도해보세요 😄 |
leokim0922
reviewed
May 11, 2024
There was a problem hiding this comment.
해당 솔루션만 시/공간 복잡도 누락된 것 같습니다 😄
leokim0922
reviewed
May 11, 2024
| ListNode node2 = node1.next; | ||
| head.next = null; | ||
|
|
||
| while (node1 != null && node2 != null) { |
There was a problem hiding this comment.
요 부분에서 굳이 node1 까지 확인한 이유가 혹시 있을까요? 위에 이미 head로 지정을 해놓으셔서 이미 while 루프에 들어간 리스트는 list1이 null 이 아님을 확인한 상태인거 같아서요!
There was a problem hiding this comment.
재귀로 접근하신게 신선한 것 같네요...! : )
| if (stack.isEmpty()) return false; | ||
|
|
||
| if (c == ')') { | ||
| Character pop = stack.pop(); |
There was a problem hiding this comment.
stack pop 부분이 각 조건문 안에서 반복되어서
빼볼 수 있지 않았을까 하는 생각이 드네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2주차 문제풀이
현생이슈로 풀이가 많이 늦었습니다 🙏🙏
링크드 리스트에 대한 이해도가 낮아서 자료구조를 더 공부해야겠네요 ㅠㅠ