[croucs] WEEK 1 #654
Merged
[croucs] WEEK 1 #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
안녕하세요 :) |
mike2ox
approved these changes
Dec 10, 2024
| class Solution: | ||
| def containsDuplicate(self, nums: List[int]) -> bool: | ||
| num_dict = {} | ||
| for num in nums: |
There was a problem hiding this comment.
입력받은 List는 정렬되지 않은 상태이기 때문에 중복된 요소간의 List내 위치가 많이 멀 경우 시간복잡도가 안좋게 잡힐 가능성이 커서 정렬한 상태에서 비교하는건 어떨까요?
Comment on lines
+5
to
+8
| if len(nums) == 0: | ||
| return 0 | ||
| elif len(nums) == 1: | ||
| return 1 |
There was a problem hiding this comment.
(사소) nums 길이가 1이하면 sorting하기 전에도 결과를 반환할 수 있어서 가지치기 느낌으로 longestConsecutive 내 최상단에 두면 더 좋아보입니다.
obzva
reviewed
Dec 11, 2024
contains-duplicate/heypaprika.py
Outdated
| @@ -0,0 +1,11 @@ | |||
| # Big-O 예상 : O(n*k) | |||
There was a problem hiding this comment.
안녕하세요
일반적으로 Big O 분석을 한다고 하면 해당 풀이의 시간 복잡도와 공간 복잡도를 분석하는 것을 뜻합니다
따라서 해당 Big O 표기가 어느 부분에 관한 분석인지 적어주시는 것이 좋을 것 같아요
또한 Big O 표기에 n, k 이렇게 두 개의 변수가 쓰이고 있는데, 각각의 변수가 어떤 걸 의미하고 있는지 적어주시면 좋을 것 같습니다 ㅎㅎ
위키에 모범 답안제출 사례들을 참고하시길 추천 드립니다
Co-authored-by: moonhyeok song <firefinger07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.