Skip to content

[KwonNayeon] Week 1 #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 15, 2024
Merged

[KwonNayeon] Week 1 #656

merged 14 commits into from
Dec 15, 2024

Conversation

KwonNayeon
Copy link
Contributor

@KwonNayeon KwonNayeon commented Dec 9, 2024

답안 제출 문제

체크 리스트

  • PR을 프로젝트에 추가하고 Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@KwonNayeon KwonNayeon requested a review from a team as a code owner December 9, 2024 03:00
@github-actions github-actions bot added the py label Dec 9, 2024
@KwonNayeon KwonNayeon requested review from y00eunji and removed request for a team December 9, 2024 03:05
@KwonNayeon KwonNayeon changed the title Add placeholder file for 'Contains Duplicate' problem [KwonNayeon] Week 1 Dec 10, 2024
@KwonNayeon KwonNayeon requested a review from a team December 10, 2024 03:38
frequency[num] += 1
else:
frequency[num] = 1
sorted_frequency = sorted(frequency.items(), key=lambda x: x[1], reverse=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

잘 풀어주신 것 같습니다. 이후 문제에서 등장하는 시간복잡도 O(nlogk)를 만족하려면 어떤 방법이 필요할지 고민해보시면 좋을 것 같습니다! 전체 데이터가 다 필요한가에 대해서 고민해보면 해답을 떠올리실 수 있을 것 같습니다! (계속 정렬 상태를 유지하면 어떨까요?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다! 말씀해주신 것 참고하여 다시 풀어보겠습니다 😁

@KwonNayeon
Copy link
Contributor Author

@DaleStudy/coach @y00eunji 코치님, 리뷰어님 안녕하세요. 코드 승인 부탁드립니다!

Copy link
Contributor

@SamTheKorean SamTheKorean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번주도 고생많으셨습니다!! 깔끔한 설명과 풀이 잘 보았습니다 ㅎㅎ

@KwonNayeon KwonNayeon merged commit 6ccc41c into DaleStudy:main Dec 15, 2024
1 check passed
@KwonNayeon
Copy link
Contributor Author

KwonNayeon commented Dec 15, 2024

@SamTheKorean 코드 승인 감사합니다 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

3 participants