Skip to content

fix(integration): Fix filename validation to compare with PR base SHA instead of latest branch #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

HC-kang
Copy link
Contributor

@HC-kang HC-kang commented Dec 9, 2024

추가된 파일을 확인하기 위해 diff 할 때, 자신의 부모가 아니라 최신 브랜치와 비교하고 있었습니다.
이로인해 중간에 누군가 다른 멤버분께서 머지하시는 경우, 통합할 수 없는 상태가 되고있었네요.

@HC-kang HC-kang requested a review from a team as a code owner December 9, 2024 10:42
@HC-kang HC-kang requested review from DaleSeo, obzva and EgonD3V and removed request for a team December 9, 2024 10:43
@HC-kang HC-kang force-pushed the integration-hotfix branch from f750a0b to 596e53a Compare December 9, 2024 11:50
@HC-kang HC-kang changed the title fix(integration): Fix filename validation to handle deleted/updated files in PR fix(integration): Fix filename validation to compare with PR base SHA instead of latest branch Dec 9, 2024
Copy link
Member

@DaleSeo DaleSeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠른 조치 감사합니다!

@HC-kang HC-kang merged commit d975b97 into DaleStudy:main Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants