[gomgom22] Week1 #687
Merged
[gomgom22] Week1 #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyKim9401
reviewed
Dec 13, 2024
contains-duplicate/YJason-K.ts
Outdated
Comment on lines
8
to
16
| let unique: Set<number> = new Set([]); | ||
| for (const num of nums) { | ||
| if (unique.has(num)) { | ||
| return true | ||
| } else { | ||
| unique.add(num) | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
아래와 같이 Set과 List의 길이를 비교하는 방법도 참고하시면 좋을것 같습니다 :)
new Set(nums).size !== nums.length;
TonyKim9401
reviewed
Dec 13, 2024
valid-palindrome/YJason-K.ts
Outdated
| * @param {string} s - 정제할 물자열 | ||
| * @returns {string} - 소문자 알파벳과 숫자로 이루어진 문자열 | ||
| */ | ||
| const refinePhrase = (s:string) : string => s.toLowerCase().replace(/[^a-z0-9]/g, ''); |
There was a problem hiding this comment.
정재 로직을 메서드화 하여 문제의 핵심인 투포인터가 눈에 띄는 좋은 풀이 방법인것 같습니다 :)
TonyKim9401
approved these changes
Dec 13, 2024
|
안녕하세요 @Yjason-K 님! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.