Skip to content

[gmlwls96] Week2 #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 22, 2024
Merged

[gmlwls96] Week2 #722

merged 4 commits into from
Dec 22, 2024

Conversation

gmlwls96
Copy link
Contributor

@gmlwls96 gmlwls96 commented Dec 16, 2024

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 StatusIn Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@gmlwls96 gmlwls96 requested a review from YeomChaeeun December 16, 2024 12:30
@gmlwls96 gmlwls96 requested a review from a team as a code owner December 16, 2024 12:30
@gmlwls96 gmlwls96 changed the title [Week2](gmlwls96) Valid-anagram [gmlwls96] Week2 Dec 16, 2024
Comment on lines +7 to +14
for (j in i + 1..nums.size - 2) {
for (k in j + 1..nums.lastIndex) {
// 2. nums의 3숫자를 뽑아내기 위해 i, j, k를 순차적으로 조회하면서 합했을때 0이 되는지 체크.
if (nums[i] + nums[j] + nums[k] == 0) {
mutableSet.add(listOf(nums[i], nums[j], nums[k]))
}
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for문이 2번 사용되었는데, 투 포인터를 사용해서 풀이해보셔도 재미있을것 같습니다!

Copy link
Contributor

@TonyKim9401 TonyKim9401 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2주차 문제풀이 고생 많으셨습니다!
공간복잡도와 코드 설명을 잘 달아주셨는데요, 공간 복잡도도 함께 있으면 더 좋을것 같습니다.
3주차도 파이팅입니다!

@gmlwls96 gmlwls96 merged commit 7c34da0 into DaleStudy:main Dec 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants