[rivkode] Week 2 #743
Merged
[rivkode] Week 2 #743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgonD3V
approved these changes
Dec 21, 2024
3sum/rivkode.py
Outdated
Comment on lines
6
to
8
| def threeSum(self, nums: List[int]) -> List[List[int]]: | ||
| result = [] | ||
| return result |
There was a problem hiding this comment.
안 푸신 문제 파일은 commit에서 제외를 부탁드립니다
| def climbStairs(self, n: int) -> int: | ||
| stage = [1, 2, 3] | ||
|
|
||
| for i in range(3, 45): |
There was a problem hiding this comment.
만약 제가 면접관이라면 문제 제약 조건을 숙지하신 어필은 좋지만, n이 45보다 작은 경우에도 계산하게 되는 점에 대해 물어볼 것 같습니다
There was a problem hiding this comment.
아..! 제가 입력값에 대한 사용을 깜빡하였습니다. 수정하였습니다. 감사합니다 :)
입력값에 대한 내용이 아니었군요. 음 .. 조금 더 고민해보겠습니다. n이 45보다 작으면 불필요한 연산이 추가되어보입니다.
Comment on lines
+20
to
+26
| solution = Solution() | ||
|
|
||
| s = "nagaram" | ||
| t = "anagram" | ||
|
|
||
| result = solution.isAnagram(s, t) | ||
| print(result) |
There was a problem hiding this comment.
Python Standard Library 중 unittest를 사용해보시면 좋을 것 같습니다
There was a problem hiding this comment.
감사합니다. 앞으로의 test는 unittest를 사용하겠습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.