Skip to content

[jdy8739] Week 7 #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 25, 2025
Merged

[jdy8739] Week 7 #919

merged 8 commits into from
Jan 25, 2025

Conversation

jdy8739
Copy link
Contributor

@jdy8739 jdy8739 commented Jan 18, 2025 •
edited
Loading

답안 제출 문제

체크 리스트

  • 우측 메뉴에서 PR을 Projects에 추가해주세요.
  • Projects의 오른쪽 버튼(▼)을 눌러 확장한 뒤, Week를 현재 주차로 설정해주세요.
  • 바로 앞에 PR을 열어주신 분을 코드 검토자로 지정해주세요.
  • 문제를 모두 푸시면 프로젝트에서 Status를 In Review로 설정해주세요.
  • 코드 검토자 1분 이상으로부터 승인을 받으셨다면 PR을 병합해주세요.

@jdy8739 jdy8739 requested a review from a team as a code owner January 18, 2025 15:21
@github-actions github-actions bot added the js label Jan 18, 2025
@jdy8739 jdy8739 requested a review from HiGeuni January 18, 2025 15:24
@jdy8739
Copy link
Contributor Author

jdy8739 commented Jan 25, 2025

@HiGeuni 안녕하세요 혹시 리뷰 가능하실까요??

HiGeuni
HiGeuni approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@HiGeuni HiGeuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 한 주도 고생 많으셨습니다!!
리뷰가 늦어서 죄송합니다 ㅠ
연휴 잘 보내시고 다음 주도 파이팅!

longest-substring-without-repeating-characters/jdy8739.js Outdated
return max;
};

//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 문제들 시간복잡도 분석도 잘 해주셨는데 누락된 거 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 그러네요! 추가했습니다. 감사합니다 :)

@jdy8739 jdy8739 merged commit a51e96e into DaleStudy:main Jan 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiGeuni HiGeuni HiGeuni approved these changes

Assignees

@jdy8739 jdy8739

Labels
js
Projects
No open projects
리트코드 스터디 3기
Status: Completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdy8739 @HiGeuni