Run tests with pytest on Github actions #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpm
reviewed
Jul 20, 2023
test/conftest.py
Outdated
| # import dlgr was not working in the context of a test. The following | ||
| # lines make sure it works. | ||
| import sys | ||
| sys.path.append(os.path.join(os.path.dirname(__file__), '..')) |
There was a problem hiding this comment.
I don't love this, can't we pip install -e . the GridUniverse package to the dlgr.griduniverse package and the dlgr namespace registered?
alecpm
reviewed
Jul 21, 2023
game_config.yml
Outdated
| @@ -0,0 +1 @@ | |||
| dlgr/griduniverse/game_config.yml | |||
There was a problem hiding this comment.
@silviot I think I fixed the issue that required this yesterday on the one-hour-one-life main branch.
alecpm
requested changes
Jul 27, 2023
There was a problem hiding this comment.
Tox was mainly used for server config and process managements stuff on Travis that GitHub actions manages for us. Tox was just running pytest. Getting rid of it is great!
I think this looks great, hopefully we can switch to Dallinger master soon. I have a couple small notes.
- I don't think you should need the
game_config.ymlsymlink if you rebase to master - I think there's probably a way to avoid that
sys.pathmanipulation by installing thedlgr.griduniversepackage as editable during the setup. That's what we do in Dallinger fordallinger.demosI think.
alecpm
force-pushed
the
issues/236-transitions
branch
from
9c7a641 to
140718b
Compare
alecpm
force-pushed
the
issues/236-transitions
branch
from
698dbf6 to
f5587cc
Compare
alecpm
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR configures Github actions to run tests using pytest.
The old travis configuration has been removed.
Currently a custom dallinger branch is being installed during tests, since this work is done in the context of supporting one-hour-one-life-like games on GU.
The old travis config used tox, but this PR uses pytest. The reason for this is that I'm not very familiar with tox.