Fixed wrong banner dimensions due to the wrong orientation detection #431
Conversation
Fixed wrong banner dimensions due to the wrong orientation detection
| return frame.width | ||
| if #available(iOS 13.0, *) { | ||
| if let scene = UIApplication.shared.connectedScenes.first as? UIWindowScene { | ||
| let orientation = UIApplication.shared.supportedInterfaceOrientations(for: scene.windows.first) |
There was a problem hiding this comment.
I'm not sure why supportedInterfaceOrientations is being checked here. Most of the time, if landscape is supported, then both .landscapeLeft and .landscapeRight would be in the mask returned. In that case, the switch would just fall through to the default of using frame.width. The same goes if both portrait and landscape orientations are supported. Shouldn't frame.width just be used all the time instead?
There was a problem hiding this comment.
It prioritizes supported orientation over the current device orientation state, for example when the app is locked in portrait, and the device is in the landscape, it returns the portrait which will result in a correct orientation. I'm not sure if it's the best way to do it but just double-checked it and it works like a charm! Please feel free to upgrade it though!
There was a problem hiding this comment.
I agree that supportedInterfaceOrientations should take priority over UIDevice.current.orientation. My point was that I think that simply checking window.frame.width or window.frame.height will take the app's current orientation (which is restricted by supported orientations) into account without needing to check for the app's supported orientations separately.
In a portrait application (in which the landscape is closed), if the device is not placed in a portrait state, the app will still be shown as portrait but the banner thinks the device is in landscape mode and shows the banner with the wrong dimensions.