Add global minor mode (#16) #17
Conversation
|
/cc @Fuco1: is this what you had in mind? |
|
I very much welcome code quality and best-practice feedback. Please don't hesitate. |
DamienCassou
force-pushed
the
add-global-minor-mode
branch
2 times, most recently
from
71be2ca to
e19013f
Compare
beginend.el
Outdated
| @@ -225,16 +225,41 @@ BEGIN-BODY and END-BODY are two `progn' expressions passed to respectively | |||
| (progn | |||
| (prodigy-last))) | |||
|
|
|||
| (add-to-list 'beginend-modes (cons 'mu4e-view-mode-hook #'beginend-message-mode)) | |||
There was a problem hiding this comment.
I would move these values directly into the defvar default value. The reason is that if alter the code is somehow reordered Emacs might complain about undefined variables.
Also people seem to not like top-level forms which aren't defXYZ (I don't have a strong opinion about this though).
There was a problem hiding this comment.
Also format it like so:
(
(...)
(...)
)
This looks weird but actually is "acceptable" in defvars and constants as it produces better diffs when lines are added/removed.
There was a problem hiding this comment.
I would move these values directly into the defvar default value
done
Emacs might complain about undefined variables
The travis build would fail if that's the case as byte-compilation warnings are interpreted as errors in the Makefile (byte-compile-error-on-warn).
Also format it like so
This indeed looks weird but let's try it.
If you are fine with it, you can merge it :-).
DamienCassou
force-pushed
the
add-global-minor-mode
branch
from
e19013f to
406c127
Compare
No description provided.