add detection for new edge chromium browser #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aaah based on the new chromium engine. |
5punk
approved these changes
Apr 14, 2019
Agreed...
Not terribly sure at this point, unfortunately my technique for staying on top of this at the moment is pretty adhoc, i.e. "Oh hey! That's a new browser I should try out. I should probably add support for detection while I'm doing it". |
|
Specifically with regards to Edge I do think we should try and keep on top of it. I'm developing on Windows at the moment so I'll do my best to do that even though I'm not using Edge in day to day dev. |
DamonOehlman
force-pushed
the
damon-edge-chromium
branch
from
f09185f
to
59efc88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be interesting to see if MS retain the shortened
EdgvsEdgein the user agent string (I doubt it). As such I expect this is a detection that will become redundant as MS transitions to chromium backed edge in stable, but I think it's probably a worthwhile detection to add for now in case anyone wants to give it special treatment in the interim.