Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add argument to the detect #114

Merged
merged 3 commits into from
Jul 7, 2019
Merged

add argument to the detect #114

merged 3 commits into from
Jul 7, 2019

Conversation

rgabaydullov
Copy link
Contributor

Very needed isomorphic browser detection

DamonOehlman
DamonOehlman requested changes Jun 18, 2019
View reviewed changes
Copy link
Owner

@DamonOehlman DamonOehlman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rshtg Thanks for the PR and apologies for the delay. A couple of comments from me, but I think getting this feature in is really important so keen to land it after those changes have been made.

src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@DamonOehlman DamonOehlman merged commit ae86296 into DamonOehlman:master Jul 7, 2019
@DamonOehlman
Copy link
Owner

Published as 4.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DamonOehlman DamonOehlman DamonOehlman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgabaydullov @DamonOehlman