Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code and tests for Opera-Mini, Silk and Chrome OS' #92

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Added code and tests for Opera-Mini, Silk and Chrome OS' #92

merged 2 commits into from
Feb 5, 2019

Conversation

sreya3
Copy link
Contributor

@sreya3 sreya3 commented Feb 5, 2019

'

@5punk
Copy link
Collaborator

5punk commented Feb 5, 2019

@sreya3 can you add a unit test or two around ChromeOS as well?

@sreya3
Copy link
Contributor Author

sreya3 commented Feb 5, 2019

@sreya3 can you add a unit test or two around ChromeOS as well?

I can though I noticed there are no unit tests for operating systems on the repo. Just for browsers

@5punk 5punk merged commit b038515 into DamonOehlman:master Feb 5, 2019
@5punk
Copy link
Collaborator

5punk commented Feb 5, 2019

@DamonOehlman Can you cut a minor release?

@sreya3 sreya3 deleted the AddingBrowsers branch February 5, 2019 23:23
@DamonOehlman
Copy link
Owner

@5punk yep - will do. Sorry only just saw the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@5punk 5punk 5punk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreya3 @5punk @DamonOehlman