refactor: Adopt the type-lens package. #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCardin
force-pushed
the
dc/type-lens
branch
2 times, most recently
from
1d875bf
to
a33b064
Compare
DanCardin
force-pushed
the
dc/type-lens
branch
2 times, most recently
from
547c740
to
2e356b9
Compare
DanCardin
force-pushed
the
dc/type-lens
branch
2 times, most recently
from
79317e9
to
4a03735
Compare
DanCardin
force-pushed
the
dc/type-lens
branch
from
4a03735
to
0baef08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not going to work in the short term. Some of the required functionality isn't merged yet, and none of it is in a released version.Also, type-lens only supports python 3.9+, which is unfortunate. Although https://pypistats.org/packages/cappa maybe implies 3.8 is currently only installed when CI runs.Also, all the variable names are currently "annotation", but probably ought to betype_view, soannotation.annotationdoesn't look so stupidExternalize all the various little version-specific python typing handling and various typing related utilities into the
type-lenspackage. Much of the type-lens API we use came from cappa's impls, but rebased on the much more comprehensiveTypeViewbase provided by it.