refactor: Pull handling of --no-* bool arguments out of the parser. #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCardin
force-pushed
the
dc/no-handling
branch
from
5afb6c9
to
6de0b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
The only thing that feels kind of weird about the implementation here (which...it really shouldn't because it's basically exactly as arbitrary as it was before) is that given some
--foo/--no-foo:--foowill unconditionallystore_trueand--no-foowill unconditionallystore_false.But given that level of information, i dont see how we could infer any other choice though, so it doesn't feel that arbitrary. And what's nice about this solution is that the user can now always manually expand the definition themselves to arrive at whatever behavior they want, without the parser inverting their stated selection.