Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Split name and field_name on Arg object. #51

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

DanCardin
Copy link
Owner

@DanCardin DanCardin commented Oct 24, 2023

Fix #46.

At current moment, name field is relatively inaccessible except for the "manual construction" usecase. It's otherwise able to be specified. Thus using such a valuable, generic name seemed unncessary. Thus name -> field_name.

With name freed up, "name" seems like a decent name for the equivalent of metavar in argparse. I suppose name could be confused with short/long?

I looked at Clap which uses value_name, which i rather like, and which seems to me to pair well with field_name. certainly better than metavar

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6626228945

  • 41 of 41 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 6618140009: 0.0%
Covered Lines: 1565
Relevant Lines: 1565

💛 - Coveralls

@DanCardin DanCardin merged commit c5a7406 into main Oct 24, 2023
6 checks passed
@DanCardin DanCardin deleted the dc/split-name-field-name branch October 29, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple arg name from rendered name
2 participants