Fix HMR #41
Merged
Fix HMR #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @esayler looks good. Not sure I follow a lot of what you did but will message back if any issues arise. Perhaps we can all walk through this tomorrow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all, I made a few organization changes to the code (added a separate
configureStore()function) and I think I fixed the HMR warnings about changing history and the reducers. Let me know if there's any problems with the app, but HMR should be working now.I also added
'inline-source-maps'to thewebpack.config.jsso we should be getting better error stack traces with sourcemaps in the console, but the component mount errors fromreact-hot-reload's utilization ofreact-redbox(i.e. the red fullscreen errors) may not have source-maps.Resources Used:
redux- Issue #667 commentreact-hot-loader- Issue # 249react-router-redux- Usage